Skip to content

SDL_Audiolib incorrectly checks for d->fRWops even for non-RWOps streams #44

@glebm

Description

@glebm

The latest commit doesn't work with DevilutionX because we have a custom decoder for videos that doesn't use rwops:

https://github.com/diasurgical/devilutionX/blob/master/Source/utils/push_aulib_decoder.h

The commit that breaks this is: b2df2df

Here is how we create the stream:

https://github.com/diasurgical/devilutionX/blob/0f90d5babab49b804ec54137d9e336835dd73a60/Source/storm/storm_svid.cpp#L261C1-L263C129

Note that we explicitly pass /*rwops=*/nullptr and /*closeRw=*/false:

SVidAudioStream.emplace(/*rwops=*/nullptr, std::move(decoder), CreateAulibResampler(audioInfo.sampleRate), /*closeRw=*/false);

Is this a bug on our side or in SDL_audiolib?

/cc @StephenCWills @AJenbo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions