Proposal: LazyCollection::strict() to block passthru()

[radmen]

I often use LazyCollections and find them helpful in different situations.

I think there is one problem with them - the underlying passthru() method.

It is justified for the use cases it supports. However, it uses collect() which means that we no longer have a truly LazyCollection. Instead we have something that collects all values and then tries to yield them again, pretending to be a generator. This might be a serious problem when dealing with large streams of data.

What if we added strict() which basically forbids using passthru()? It would definitely limit the versatility of LazyCollection, though on the other hand, it would ensure that the collection remains lazy.

Edit: If this proposal makes sense, I would gladly work on the implementation.

[macropay-solutions]

Another pitfall... Great...
That method should had never be added there.... devs should manually convert the lazy collection into a collection (so that the logic is not hidden in the framework). Now it is what it is...

Thank for the heads up. We documented this edge case in our projects.

[henzeb]

I think these all use passthru. I don't think you can make most of them used Lazy...

avg()
average()
combine()
count()
crossJoin()
diff()
diffAssoc()
diffKeys()
first()
implode()
intersect()
intersectByKeys()
join()
last()
max()
mergeRecursive()
min()
random()
replaceRecursive()
reverse()
shuffle()
sort()
sortBy()
sortByDesc()
sortDesc()
sortKeys()
sortKeysDesc()
split()
splitIn()
sum()
toArray()
toJson()