-
Notifications
You must be signed in to change notification settings - Fork 72
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
After bumping the protobufs in the Python SDK, there are fields in the token transaction that are missing in the SDK:
- Missing in the
TokenCreateTransactionclass:
Timestamp expiry = 13;
AccountID autoRenewAccount = 14;
Duration autoRenewPeriod = 15;
string memo = 16;
Key fee_schedule_key = 20;
Key fee_schedule_key = 20;
- Missing in the
TokenUpdateTransactionclass:
AccountID autoRenewAccount = 10;
Duration autoRenewPeriod = 11;
Timestamp expiry = 12;
Key fee_schedule_key = 14;
Key kycKey = 6;
- Also, there are missing integration tests for both transactions
Protobufs for TokenCreateTransaction and TokenUpdateTransaction
- https://github.com/hashgraph/hedera-protobufs/blob/v0.66.0/services/token_update.proto
- https://github.com/hashgraph/hedera-protobufs/blob/v0.66.0/services/token_create.proto
Solution
- Implement the missing fields by referencing their definitions in the protobufs and reviewing implementations in other SDKs.
- Add additional
integration teststo validate the new fields. Reference similar tests in other SDKs for guidance: - Add more
unit testsfor the new fields
Alternatives
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request