Skip to content

Commit 1214c7c

Browse files
author
shleewhite
committed
cleanup
1 parent 1bf2b56 commit 1214c7c

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

.changeset/rich-zoos-type.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"@hashicorp/design-system-components": patch
3+
---
4+
5+
<!-- START components/modal -->
6+
`Modal` - Refactored the component to not use `ember-render-modifiers` which fixes issues where the DOM may not be cleaned up when the Modal is closed.
7+
<!-- END -->
8+
9+
<!-- START components/flyout -->
10+
`Flyout` - Refactored the component to not use `ember-render-modifiers` which fixes issues where the DOM may not be cleaned up when the Flyout is closed.
11+
<!-- END -->

packages/components/src/components/hds/flyout/index.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -166,18 +166,6 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
166166
};
167167
});
168168

169-
@action
170-
willDestroyNode(): void {
171-
if (this._element) {
172-
this._element.removeEventListener(
173-
'close',
174-
// eslint-disable-next-line @typescript-eslint/unbound-method
175-
this.registerOnCloseCallback,
176-
true
177-
);
178-
}
179-
}
180-
181169
@action
182170
open(): void {
183171
// Make flyout dialog visible using the native `showModal` method

0 commit comments

Comments
 (0)