Skip to content

AcceptDialog emits canceled even when invisible #110381

@dagarsar

Description

@dagarsar

Tested versions

  • Reproducible in 4.5.rc1

System information

Godot v4.5.rc1 - Windows 11 (build 26100) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; 32.0.15.6094) - 13th Gen Intel(R) Core(TM) i5-13500 (20 threads) - 31.78 GiB memory

Issue description

AcceptDialog emits canceled when propagate_notification(NOTIFICATION_WM_CLOSE_REQUEST) is called, even if the dialog is not visible. This brings unintended side effects to the propagation of that notification.

Steps to reproduce

  1. Connect the canceled signal of an AcceptDialog to any method
  2. Set the AcceptDialog to invisible
  3. Call propagate_notification(NOTIFICATION_WM_CLOSE_REQUEST)

Minimal reproduction project (MRP)

canceled_mrp.zip

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions