Skip to content

feat: Update fmt to 11.2.0 #15159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Update fmt to 11.2.0 #15159

wants to merge 1 commit into from

Conversation

@czentgr
Copy link
Collaborator

@czentgr czentgr commented Oct 14, 2025

No description provided.

@netlify
Copy link

netlify bot commented Oct 14, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 35b0b82
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/68f661f468a68e0008300cc2

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 14, 2025

@kgpai has imported this pull request. If you are a Meta employee, you can view this in D84624987.

@czentgr
Copy link
Collaborator Author

czentgr commented Oct 15, 2025

Removing the commit with the new dependency images. Run with the new dependency images was all green.

@czentgr czentgr marked this pull request as ready for review October 15, 2025 14:59
czentgr
czentgr commented Oct 15, 2025
View reviewed changes
CMake/resolve_dependency_modules/README.md Outdated
| xsimd | 10.0.0 | Yes |
| re2 | 2024-07-02 | Yes |
| fmt | 10.1.1 | Yes |
| fmt | 11.2.0 | Yes |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main CMakeLists we only require version 9.0.0 and later. So this version is not directly enforced.
There was a problem with the previous upgrade. Not a problem in the CI later on when we use a newer CLang because that will use the new version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment regarding that though - that we should avoid api's that are not present in 9.0.0 .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can enforce it in the cmake. If an older version is found it will be using the new bundled version.
I think the reason that it is still 9.0.0 is for backwards compatibility with additional code (outside of this repo) that uses an older fmt version. Or this isn't necessary anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will use the newer bundled version ,which is fine, but should point out that code that is not backwards compatible with 9.0.0 risks chance of being reverted (Its unfair on our part to add this additionally on developers , but I believe in most cases they are compatible , so hopefully its not too bad.)

kgpai
kgpai approved these changes Oct 17, 2025
View reviewed changes
CMake/resolve_dependency_modules/README.md Outdated
| xsimd | 10.0.0 | Yes |
| re2 | 2024-07-02 | Yes |
| fmt | 10.1.1 | Yes |
| fmt | 11.2.0 | Yes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment regarding that though - that we should avoid api's that are not present in 9.0.0 .

@czentgr czentgr force-pushed the cz_upgrade_fmt branch 2 times, most recently from 6dc2dad to 7507ffe Compare October 17, 2025 22:55
@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 19, 2025
@meta-codesync meta-codesync bot closed this in 9320068 Oct 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 20, 2025

@kgpai merged this pull request in 9320068.

mhaseeb123 pushed a commit to mhaseeb123/velox that referenced this pull request Oct 27, 2025
@czentgr @mhaseeb123
feat: Update fmt to 11.2.0 (facebookincubator#15159)
e8623ea 
Summary: Pull Request resolved: facebookincubator#15159

Reviewed By: kKPulla

Differential Revision: D84624987

Pulled By: kgpai

fbshipit-source-id: 8b95d426b0bce93fc1351e54a4abdcf67d0adf7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgpai kgpai kgpai approved these changes

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@czentgr @kgpai @assignUser @facebook-github-bot