Merge pull request #53 from circles-learning-labs/issue_48

Fix BillingModeSummary issue that affected migrations

Author: alhambra1

lib/ecto_adapters_dynamodb/migration.ex

@@ -331,7 +331,7 @@ defmodule Ecto.Adapters.DynamoDB.Migration do
   # that attempt to add an index to a provisioned table without specifying throughput. The problem doesn't exist
   # the other way around; local Dynamo will ignore throughput specified for indexes where the table is on-demand.
   defp maybe_default_throughput_local(_using_ddb_local, data, table_info) do
-    if table_info["BillingModeSummary"]["BillingMode"] == "PROVISIONED" do
+    if not Map.has_key?(table_info, "BillingModeSummary") or table_info["BillingModeSummary"]["BillingMode"] == "PROVISIONED" do
       updated_global_secondary_index_updates =
         for index_update <- data.global_secondary_index_updates, {action, index_info} <- index_update do
           if action in [:create, :update] do

test/ecto_adapters_dynamodb/info_test.exs

@@ -14,10 +14,6 @@ defmodule Ecto.Adapters.DynamoDB.Info.Test do
         %{"AttributeName" => "mass", "AttributeType" => "N"},
         %{"AttributeName" => "name", "AttributeType" => "S"}
       ],
-      "BillingModeSummary" => %{
-        "BillingMode" => "PROVISIONED",
-        "LastUpdateToPayPerRequestDateTime" => 0.0
-      },
      "GlobalSecondaryIndexes" => [
         %{
           "IndexArn" => "arn:aws:dynamodb:ddblocal:000000000000:table/test_planet/index/name_mass",

test/ecto_adapters_dynamodb/migration_test.exs

@@ -38,10 +38,8 @@ defmodule Ecto.Adapters.DynamoDB.Migration.Test do
 
     test "create: provisioned table" do
       result = Ecto.Migrator.run(TestRepo, @migration_path, :up, step: 1)
-      table_info = Ecto.Adapters.DynamoDB.Info.table_info("cat")
 
       assert length(result) == 1
-      assert table_info["BillingModeSummary"]["BillingMode"] == "PROVISIONED"
     end
 
     test "alter table: add index to on-demand table" do

test/integration/ex_aws_dynamo_test.exs

@@ -14,7 +14,6 @@ defmodule Ecto.Adapters.DynamoDB.Integration.ExAws.Dynamo.Test do
     {:ok, table_info} = ExAws.Dynamo.describe_table(@ex_aws_dynamo_test_table_name) |> ExAws.request()
 
     assert table_info["Table"]["TableName"] == @ex_aws_dynamo_test_table_name
-    assert table_info["Table"]["BillingModeSummary"]["BillingMode"] == "PROVISIONED"
   end
 
   test "update_table" do