Don't hash in preparePassphrase to make integration test pass!

Author: Anviking

lib/core-integration/src/Test/Integration/Scenario/API/Byron/Transactions.hs

@@ -62,7 +62,7 @@ import Data.Text.Class
 import Numeric.Natural
     ( Natural )
 import Test.Hspec
-    ( ActionWith, SpecWith, describe, pendingWith )
+    ( ActionWith, SpecWith, describe )
 import Test.Hspec.Expectations.Lifted
     ( shouldBe, shouldNotBe )
 import Test.Hspec.Extra
@@ -123,7 +123,6 @@ import qualified Cardano.Wallet.Primitive.Types.TokenPolicy as TokenPolicy
 import qualified Data.ByteString as BS
 import qualified Data.ByteString.Char8 as B8
 import qualified Data.Text as T
-import qualified Data.Text.Encoding as T
 import qualified Network.HTTP.Types.Status as HTTP
 
 data TestCase a = TestCase

lib/core/src/Cardano/Wallet/Primitive/AddressDerivation.hs

@@ -104,7 +104,7 @@ import Control.Monad
 import Crypto.Hash
     ( Digest, HashAlgorithm )
 import Crypto.Hash.Utils
-    ( blake2b224, blake2b256 )
+    ( blake2b224 )
 import Crypto.KDF.PBKDF2
     ( Parameters (..), fastPBKDF2_SHA512 )
 import Crypto.Random.Types
@@ -585,17 +585,17 @@ encryptPassphrase  (Passphrase bytes) = do
         <> BA.convert @ByteString (fastPBKDF2_SHA512 params bytes salt)
 
 -- | Manipulation done on legacy passphrases before getting encrypted.
+--
+-- NOTE March 2022:
+-- It seems like the idea that some manipulation should be done was incorrect.
+-- We could remove this fucntion then.
 preparePassphrase
     :: PassphraseScheme
     -> Passphrase "raw"
     -> Passphrase "encryption"
 preparePassphrase = \case
     EncryptWithPBKDF2 -> coerce
-    EncryptWithScrypt -> Passphrase . hashMaybe
-  where
-    hashMaybe pw@(Passphrase bytes)
-        | pw == mempty = BA.convert bytes
-        | otherwise = BA.convert $ blake2b256 bytes
+    EncryptWithScrypt -> coerce
 
 -- | Check whether a 'Passphrase' matches with a stored 'Hash'
 checkPassphrase