Skip to content

Commit dcde553

Browse files
committed
Add code frpm PR amitshekhariitbhu#6 - Fix staticcheck issues
1 parent 0a91abc commit dcde553

File tree

3 files changed

+15
-39
lines changed

3 files changed

+15
-39
lines changed

domain/jwt_custom.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import (
77
type JwtCustomClaims struct {
88
Name string `json:"name"`
99
ID string `json:"id"`
10-
jwt.StandardClaims
10+
jwt.RegisteredClaims
1111
}
1212

1313
type JwtCustomRefreshClaims struct {
1414
ID string `json:"id"`
15-
jwt.StandardClaims
15+
jwt.RegisteredClaims
1616
}

internal/tokenutil/tokenutil.go

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ import (
99
)
1010

1111
func CreateAccessToken(user *domain.User, secret string, expiry int) (accessToken string, err error) {
12-
exp := time.Now().Add(time.Hour * time.Duration(expiry)).Unix()
12+
nowTime := time.Now()
13+
expireTime := nowTime.Add(time.Duration(expiry) * time.Hour)
14+
1315
claims := &domain.JwtCustomClaims{
1416
Name: user.Name,
1517
ID: user.ID.Hex(),
16-
StandardClaims: jwt.StandardClaims{
17-
ExpiresAt: exp,
18+
RegisteredClaims: jwt.RegisteredClaims{
19+
ExpiresAt: jwt.NewNumericDate(expireTime),
1820
},
1921
}
2022
token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)
@@ -26,10 +28,13 @@ func CreateAccessToken(user *domain.User, secret string, expiry int) (accessToke
2628
}
2729

2830
func CreateRefreshToken(user *domain.User, secret string, expiry int) (refreshToken string, err error) {
31+
nowTime := time.Now()
32+
expireTime := nowTime.Add(time.Duration(expiry) * time.Hour)
33+
2934
claimsRefresh := &domain.JwtCustomRefreshClaims{
3035
ID: user.ID.Hex(),
31-
StandardClaims: jwt.StandardClaims{
32-
ExpiresAt: time.Now().Add(time.Hour * time.Duration(expiry)).Unix(),
36+
RegisteredClaims: jwt.RegisteredClaims{
37+
ExpiresAt: jwt.NewNumericDate(expireTime),
3338
},
3439
}
3540
token := jwt.NewWithClaims(jwt.SigningMethodHS256, claimsRefresh)
@@ -43,7 +48,7 @@ func CreateRefreshToken(user *domain.User, secret string, expiry int) (refreshTo
4348
func IsAuthorized(requestToken string, secret string) (bool, error) {
4449
_, err := jwt.Parse(requestToken, func(token *jwt.Token) (interface{}, error) {
4550
if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
46-
return nil, fmt.Errorf("Unexpected signing method: %v", token.Header["alg"])
51+
return nil, fmt.Errorf("unexpected signing method: %v", token.Header["alg"])
4752
}
4853
return []byte(secret), nil
4954
})
@@ -56,19 +61,18 @@ func IsAuthorized(requestToken string, secret string) (bool, error) {
5661
func ExtractIDFromToken(requestToken string, secret string) (string, error) {
5762
token, err := jwt.Parse(requestToken, func(token *jwt.Token) (interface{}, error) {
5863
if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
59-
return nil, fmt.Errorf("Unexpected signing method: %v", token.Header["alg"])
64+
return nil, fmt.Errorf("unexpected signing method: %v", token.Header["alg"])
6065
}
6166
return []byte(secret), nil
6267
})
63-
6468
if err != nil {
6569
return "", err
6670
}
6771

6872
claims, ok := token.Claims.(jwt.MapClaims)
6973

7074
if !ok && !token.Valid {
71-
return "", fmt.Errorf("Invalid Token")
75+
return "", fmt.Errorf("invalid Token")
7276
}
7377

7478
return claims["id"].(string), nil

mongo/mongo.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,8 @@ package mongo
22

33
import (
44
"context"
5-
"errors"
6-
"reflect"
75
"time"
86

9-
"go.mongodb.org/mongo-driver/bson/bsoncodec"
10-
"go.mongodb.org/mongo-driver/bson/bsonrw"
11-
"go.mongodb.org/mongo-driver/bson/bsontype"
127
"go.mongodb.org/mongo-driver/mongo"
138
"go.mongodb.org/mongo-driver/mongo/options"
149
"go.mongodb.org/mongo-driver/mongo/readpref"
@@ -73,34 +68,11 @@ type mongoSession struct {
7368
mongo.Session
7469
}
7570

76-
type nullawareDecoder struct {
77-
defDecoder bsoncodec.ValueDecoder
78-
zeroValue reflect.Value
79-
}
80-
81-
func (d *nullawareDecoder) DecodeValue(dctx bsoncodec.DecodeContext, vr bsonrw.ValueReader, val reflect.Value) error {
82-
if vr.Type() != bsontype.Null {
83-
return d.defDecoder.DecodeValue(dctx, vr, val)
84-
}
85-
86-
if !val.CanSet() {
87-
return errors.New("value not settable")
88-
}
89-
if err := vr.ReadNull(); err != nil {
90-
return err
91-
}
92-
// Set the zero value of val's type:
93-
val.Set(d.zeroValue)
94-
return nil
95-
}
96-
9771
func NewClient(connection string) (Client, error) {
98-
9972
time.Local = time.UTC
10073
c, err := mongo.NewClient(options.Client().ApplyURI(connection))
10174

10275
return &mongoClient{cl: c}, err
103-
10476
}
10577

10678
func (mc *mongoClient) Ping(ctx context.Context) error {

0 commit comments

Comments
 (0)