-
Notifications
You must be signed in to change notification settings - Fork 228
Fix multiple-chain method ambiguity #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Turing.jl documentation for PR #2670 is available at: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 85.70% 85.86% +0.15%
==========================================
Files 22 22
Lines 1434 1429 -5
==========================================
- Hits 1229 1227 -2
+ Misses 205 202 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17555845014Details
💛 - Coveralls |
651da93
to
90c5a3e
Compare
90c5a3e
to
b4ac1d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a change to make here or to make an issue for to avoid this in the future?
Honestly no, it's just that |
I guess there is a larger problem that the codebase is not perfect, but that's my full-time job so I can't snap a finger and fix it ;) |
I was wondering if there was any CI checking that could be setup for downstream deps or anything like that. |
TuringLang/DynamicPPL.jl#1035 introduces a method ambiguity with a stray method in Turing.
This PR removes that method.