Skip to content

Conversation

penelopeysm
Copy link
Member

TuringLang/DynamicPPL.jl#1035 introduces a method ambiguity with a stray method in Turing.

This PR removes that method.

Copy link
Contributor

github-actions bot commented Sep 5, 2025

Turing.jl documentation for PR #2670 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2670/

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (0a6a10b) to head (97ec233).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   85.70%   85.86%   +0.15%     
==========================================
  Files          22       22              
  Lines        1434     1429       -5     
==========================================
- Hits         1229     1227       -2     
+ Misses        205      202       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Sep 5, 2025

Pull Request Test Coverage Report for Build 17555845014

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.719%

Totals Coverage Status
Change from base Build 17249540955: 0.2%
Covered Lines: 1193
Relevant Lines: 1425

💛 - Coveralls

@penelopeysm penelopeysm force-pushed the py/no-repeat-sampler-method branch from 651da93 to 90c5a3e Compare September 5, 2025 14:54
@penelopeysm penelopeysm force-pushed the py/no-repeat-sampler-method branch from 90c5a3e to b4ac1d3 Compare September 5, 2025 14:54
Copy link

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a change to make here or to make an issue for to avoid this in the future?

@penelopeysm
Copy link
Member Author

Honestly no, it's just that resume_from was broken for multiple chains and I fixed it, and in the process of fixing it there was this incompatibility between latest DynamicPPL and latest Turing over the weekend. This isn't reflective of any larger underlying problem imo

@penelopeysm
Copy link
Member Author

I guess there is a larger problem that the codebase is not perfect, but that's my full-time job so I can't snap a finger and fix it ;)

@seabbs
Copy link

seabbs commented Sep 8, 2025

I was wondering if there was any CI checking that could be setup for downstream deps or anything like that.

@penelopeysm penelopeysm merged commit 296f654 into main Sep 8, 2025
30 of 33 checks passed
@penelopeysm penelopeysm deleted the py/no-repeat-sampler-method branch September 8, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants