Skip to content

Commit e8e6097

Browse files
committed
wip: show data connectors on namespace page
1 parent 279f877 commit e8e6097

File tree

5 files changed

+360
-318
lines changed

5 files changed

+360
-318
lines changed

client/src/features/dataConnectorsV2/components/DataConnectorDisplay.tsx renamed to client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx

Lines changed: 4 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
Button,
2323
Col,
2424
DropdownItem,
25-
ListGroupItem,
2625
Modal,
2726
ModalBody,
2827
ModalFooter,
@@ -31,11 +30,10 @@ import {
3130
} from "reactstrap";
3231

3332
import { Loader } from "../../../components/Loader";
34-
import DataConnectorModal from "../../dataConnectorsV2/components/DataConnectorModal";
33+
// import DataConnectorModal from "./DataConnectorModal";
3534
import type { DataConnectorRead } from "../../projectsV2/api/data-connectors.api";
3635
import { useDeleteDataConnectorsByDataConnectorIdMutation } from "../../projectsV2/api/projectV2.enhanced-api";
3736
import DataConnectorCredentialsModal from "./DataConnectorCredentialsModal";
38-
import DataConnectorView from "./DataConnectorView";
3937
import { ButtonWithMenuV2 } from "../../../components/buttons/Button";
4038

4139
interface DataSourceDeleteModalProps {
@@ -109,12 +107,10 @@ function DataSourceDeleteModal({
109107
</Modal>
110108
);
111109
}
112-
export function DataSourceActions({
110+
export default function DataConnectorActions({
113111
dataConnector,
114-
projectId,
115112
}: {
116113
dataConnector: DataConnectorRead;
117-
projectId: string;
118114
}) {
119115
const [isCredentialsOpen, setCredentialsOpen] = useState(false);
120116
const [isDeleteOpen, setIsDeleteOpen] = useState(false);
@@ -172,70 +168,13 @@ export function DataSourceActions({
172168
isOpen={isDeleteOpen}
173169
toggleModal={toggleDelete}
174170
/>
171+
{/* TODO: integrate DataConnectorModal
175172
<DataConnectorModal
176173
currentStorage={dataConnector}
177174
isOpen={isEditOpen}
178175
toggle={toggleEdit}
179176
projectId={projectId}
180-
/>
181-
</>
182-
);
183-
}
184-
interface DataConnectorDisplayProps {
185-
dataConnector: DataConnectorRead;
186-
projectId: string;
187-
}
188-
189-
export function DataConnectorDisplay({
190-
dataConnector,
191-
projectId,
192-
}: DataConnectorDisplayProps) {
193-
const storageSensitive = dataConnector.storage;
194-
const [toggleView, setToggleView] = useState(false);
195-
const toggleDetails = useCallback(() => {
196-
setToggleView((open: boolean) => !open);
197-
}, []);
198-
199-
const storageType = storageSensitive?.storage_type ? (
200-
<>
201-
{" "}
202-
<span className="fst-italic" data-cy="data-storage-type">
203-
(type: {storageSensitive.storage_type})
204-
</span>
205-
</>
206-
) : null;
207-
208-
const storageName = (
209-
<span className="fw-bold" data-cy="data-storage-name">
210-
{storageSensitive.name}
211-
</span>
212-
);
213-
214-
return (
215-
<>
216-
<ListGroupItem
217-
action
218-
className={cx("cursor-pointer", "link-primary", "text-body")}
219-
onClick={toggleDetails}
220-
>
221-
<Row className={cx("align-items-center", "g-2")}>
222-
<Col>
223-
<span>
224-
{storageName}
225-
{storageType}
226-
</span>
227-
</Col>
228-
<Col xs={12} sm="auto" className="ms-auto">
229-
<DataSourceActions storage={storage} projectId={projectId} />
230-
</Col>
231-
</Row>
232-
</ListGroupItem>
233-
<DataConnectorView
234-
dataConnector={dataConnector}
235-
setToggleView={toggleDetails}
236-
toggleView={toggleView}
237-
projectId={projectId}
238-
/>
177+
/> */}
239178
</>
240179
);
241180
}

client/src/features/dataConnectorsV2/components/DataConnectorListDisplay.tsx

Lines changed: 0 additions & 230 deletions
This file was deleted.

0 commit comments

Comments
 (0)