Image Upload for Cms Page link

[Morgy93]

Hello,

is there a reason why "Cms Page Link" has no image upload feature?

It's only for ['category', 'product', 'custom_url'] - why not for all of them?

I'd love to create a PR for it, but maybe there's a reason not to offer that feature. 🤔

[andrzejborkowski]

hey @Morgy93,
I can't recall why we didn't add image upload feature fro CMS page node type 🤔 So I'd appreciate if you can create PR, then our developer can perform CR and then we can add this feature to the next release. Thanks in advance!

[andrzejborkowski]

Thank you for PR, I created an internal ticket SMM-47 and we'll review your code soon

[kruchy8]

@andrzejborkowski @Morgy93
Image upload feature is limited to['category', 'product', 'custom_url'] because only these types support <img> tag display:

https://github.com/SnowdogApps/magento2-menu/blob/develop/view/frontend/templates/hyva-topmenu-desktop/menu/node_type/category.phtml#L25

https://github.com/SnowdogApps/magento2-menu/blob/develop/view/frontend/templates/menu/node_type/custom_url.phtml#L52

https://github.com/SnowdogApps/magento2-menu/blob/develop/view/frontend/templates/menu/node_type/product.phtml#L40

In CMS Page LInk there is only text display:

https://github.com/SnowdogApps/magento2-menu/blob/develop/view/frontend/templates/menu/node_type/cms_page.phtml#L27