Start adding Pest mutation testing (#77)

* Fix mutation errors on `LoginController`

* Fix mutation errors on `RegisterController`

Author: SebKay

app/Http/Controllers/LoginController.php

@@ -10,14 +10,12 @@ class LoginController extends Controller
 {
     public function show(Request $request)
     {
-        $isProd = app()->environment('production');
-
-        return inertia('Login/Show', [
-            'email' => ! $isProd ? config('app.seed.emails.super', '') : '',
-            'password' => ! $isProd ? '12345' : '',
-            'remember' => ! $isProd ? true : false,
+        return inertia('Login/Show', app()->environment('local', 'testing') ? [
+            'email' => config('app.seed.emails.super'),
+            'password' => '12345',
+            'remember' => true,
             'redirect' => $request->query('redirect', ''),
-        ]);
+        ] : []);
     }
 
     public function store(LoginStoreRequest $request)
@@ -29,8 +27,6 @@ public function store(LoginStoreRequest $request)
             ])
         );
 
-        $request->session()->regenerate();
-
         if ($request->validated('redirect')) {
             return redirect()->to($request->validated('redirect'));
         }

app/Http/Controllers/RegisterController.php

@@ -5,13 +5,12 @@
 use App\Enums\Role;
 use App\Http\Requests\Register\RegisterStoreRequest;
 use App\Models\User;
-use Illuminate\Auth\Events\Registered;
 
 class RegisterController extends Controller
 {
     public function show()
     {
-        return inertia('Register/Show', app()->environment('local') ? [
+        return inertia('Register/Show', app()->environment('local', 'testing') ? [
             'first_name' => 'Jim',
             'last_name' => 'Gordon',
             'email' => 'test@test.com',
@@ -37,8 +36,6 @@ public function store(RegisterStoreRequest $request)
 
         auth()->guard()->loginUsingId($user->id);
 
-        event(new Registered($user));
-
         return redirect()->route('home');
     }
 }

tests/Feature/Controllers/LoginControllerTest.php

@@ -11,6 +11,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\post;
 
+covers(App\Http\Controllers\LoginController::class);
+
 describe('Users', function () {
     test("Can't access the login page", function () {
         actingAs(User::factory()->create())
@@ -26,6 +28,25 @@
             ->assertInertia(
                 fn (Assert $page) => $page
                     ->component('Login/Show')
+                    ->where('email', config('app.seed.emails.super'))
+                    ->where('password', '12345')
+                    ->where('remember', true)
+                    ->where('redirect', '')
+            );
+    });
+
+    test('Props are not passed to the show page in production', function () {
+        app()->instance('env', 'production');
+
+        get(route('login'))
+            ->assertOk()
+            ->assertInertia(
+                fn (Assert $page) => $page
+                    ->component('Login/Show')
+                    ->missing('email')
+                    ->missing('password')
+                    ->missing('remember')
+                    ->missing('redirect')
             );
     });
 

tests/Feature/Controllers/RegisterControllerTest.php

@@ -12,6 +12,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\post;
 
+covers(App\Http\Controllers\RegisterController::class);
+
 describe('Users', function () {
     test("Can't access the register page", function () {
         actingAs(User::factory()->create())
@@ -27,6 +29,27 @@
             ->assertInertia(
                 fn (Assert $page) => $page
                     ->component('Register/Show')
+                    ->has('first_name')
+                    ->has('last_name')
+                    ->has('email')
+                    ->has('password')
+                    ->has('organisation_name')
+            );
+    });
+
+    test('Props are not passed to the show page in production', function () {
+        app()->instance('env', 'production');
+
+        get(route('register'))
+            ->assertOk()
+            ->assertInertia(
+                fn (Assert $page) => $page
+                    ->component('Register/Show')
+                    ->missing('first_name')
+                    ->missing('last_name')
+                    ->missing('email')
+                    ->missing('password')
+                    ->missing('organisation_name')
             );
     });