Merge pull request #5 from JackHowa/corejs-snafu

Jack Howard · web-flow · commit 29a77e039b9e · 2021-01-10T10:46:01.000Z
Corejs snafu
diff --git a/app.js b/app.js
@@ -1,5 +1,3 @@
-// hopefully not used in modern
-
 const destructureThisArr = ['testing', 'esmodules']
 
 // destructure
diff --git a/dist/app.legacy.js b/dist/app.legacy.js
diff --git a/index.html b/index.html
@@ -7,12 +7,6 @@
     <title>module/nomodule faceoff</title>
     <meta name="description" content="Faceoff nomodule vs module" />
     <meta name="author" content="jackhowa" />
-    <!-- <script
-      nomodule
-      src="https://cdnjs.cloudflare.com/ajax/libs/core-js/3.8.2/minified.js"
-      integrity="sha512-2cm+mPqlHOfzWZq17TAQNsGrj6GJ5Hf6fOWp3Sb6Jdol3RLQEn1wwf6a7Nq6CL4bcDQLpqBuk6u6EhktEw56Fw=="
-      crossorigin="anonymous"
-    ></script> -->
   </head>
 
   <body>
diff --git a/legacy-webpack.config.js b/legacy-webpack.config.js
@@ -15,21 +15,24 @@ module.exports = {
       {
         test: /\.m?js$/,
         // don't transpile regenerator-runtime
-        exclude: [/regenerator-runtime/],
+        exclude: [/regenerator-runtime/, /core-js/],
         use: {
           loader: 'babel-loader',
           options: {
             presets: [
               [
                 '@babel/preset-env',
                 {
+                  modules: 'commonjs',
                   targets: {
                     edge: '14',
                     ie: '11',
                     firefox: '52',
                     chrome: '43',
                     safari: '9',
                   },
+                  useBuiltIns: 'usage',
+                  corejs: 3
                 },
               ],
             ],
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -36,6 +36,7 @@
     "webpack-cli": "^4.3.1"
   },
   "dependencies": {
-    "@babel/runtime": "^7.12.5"
+    "@babel/runtime": "^7.12.5",
+    "core-js": "^3.8.2"
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-// hopefully not used in modern`
`2`		`-`
`3`	`1`	`const destructureThisArr = ['testing', 'esmodules']`
`4`	`2`
`5`	`3`	`// destructure`