Skip to content

Commit bb108b4

Browse files
committed
chore: linter fixes
1 parent f4420a1 commit bb108b4

File tree

12 files changed

+109
-67
lines changed

12 files changed

+109
-67
lines changed

devcycle_python_sdk/api/local_bucketing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def store_config(self, config_json: str) -> None:
359359
config_addr = self._new_assembly_script_byte_array(data)
360360
self.setConfigDataUTF8(self.wasm_store, self.sdk_key_addr, config_addr)
361361

362-
def get_config_metadata(self) -> dict:
362+
def get_config_metadata(self) -> Optional[ConfigMetadata]:
363363
with self.wasm_lock:
364364
config_addr = self.getConfigMetadata(self.wasm_store, self.sdk_key_addr)
365365
config_bytes = self._read_assembly_script_string(config_addr)

devcycle_python_sdk/managers/config_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from wsgiref.handlers import format_date_time
1717
from devcycle_python_sdk.options import DevCycleLocalOptions
1818
from devcycle_python_sdk.managers.sse_manager import SSEManager
19+
from devcycle_python_sdk.models.config_metadata import ConfigMetadata
1920

2021
logger = logging.getLogger(__name__)
2122

@@ -108,7 +109,7 @@ def _get_config(self, last_modified: Optional[float] = None):
108109
)
109110
self._polling_enabled = False
110111

111-
def get_config_metadata(self) -> dict:
112+
def get_config_metadata(self) -> Optional[ConfigMetadata]:
112113
return self._local_bucketing.get_config_metadata()
113114

114115
def run(self):

devcycle_python_sdk/models/config_metadata.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from devcycle_python_sdk.models.environment_metadata import EnvironmentMetadata
22
from devcycle_python_sdk.models.project_metadata import ProjectMetadata
3+
from typing import Dict, Any, Optional
34
import json
45

56

@@ -16,10 +17,16 @@ def to_json(self) -> str:
1617
return json.dumps(self, default=lambda o: o.__dict__)
1718

1819
@staticmethod
19-
def from_json(json_str: str) -> "ConfigMetadata":
20-
if json_str is None:
20+
def from_json(json_obj: Optional[Dict[str, Any]]) -> Optional["ConfigMetadata"]:
21+
if json_obj is None:
2122
return None
23+
project = ProjectMetadata.from_json(json_obj.get("project"))
24+
environment = EnvironmentMetadata.from_json(json_obj.get("environment"))
25+
26+
if project is None or environment is None:
27+
return None
28+
2229
return ConfigMetadata(
23-
project=ProjectMetadata.from_json(json_str["project"]),
24-
environment=EnvironmentMetadata.from_json(json_str["environment"]),
25-
)
30+
project=project,
31+
environment=environment,
32+
)
Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
from typing import Dict, Any, Optional
2+
3+
14
class EnvironmentMetadata:
25
def __init__(
36
self,
@@ -8,10 +11,12 @@ def __init__(
811
self.key = key
912

1013
@staticmethod
11-
def from_json(json_str: str) -> "EnvironmentMetadata":
12-
if json_str is None:
14+
def from_json(
15+
json_obj: Optional[Dict[str, Any]],
16+
) -> Optional["EnvironmentMetadata"]:
17+
if json_obj is None:
1318
return None
1419
return EnvironmentMetadata(
15-
id=json_str["id"],
16-
key=json_str["key"],
17-
)
20+
id=json_obj["id"],
21+
key=json_obj["key"],
22+
)

devcycle_python_sdk/models/eval_hook_context.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
1-
from typing import Any
1+
from typing import Any, Optional
22

33
from devcycle_python_sdk.models.user import DevCycleUser
44
from devcycle_python_sdk.models.config_metadata import ConfigMetadata
55

6+
67
class HookContext:
7-
def __init__(self, key: str, user: DevCycleUser, default_value: Any, config_metadata: ConfigMetadata = None):
8+
def __init__(
9+
self,
10+
key: str,
11+
user: DevCycleUser,
12+
default_value: Any,
13+
config_metadata: Optional[ConfigMetadata] = None,
14+
):
815
self.key = key
916
self.default_value = default_value
1017
self.user = user
Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
from typing import Dict, Any, Optional
2+
3+
14
class ProjectMetadata:
25
def __init__(
36
self,
@@ -8,10 +11,10 @@ def __init__(
811
self.key = key
912

1013
@staticmethod
11-
def from_json(json_str: str) -> "ProjectMetadata":
12-
if json_str is None:
14+
def from_json(json_obj: Optional[Dict[str, Any]]) -> Optional["ProjectMetadata"]:
15+
if json_obj is None:
1316
return None
1417
return ProjectMetadata(
15-
id=json_str["id"],
16-
key=json_str["key"],
17-
)
18+
id=json_obj["id"],
19+
key=json_obj["key"],
20+
)

devcycle_python_sdk/options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def __init__(
9090

9191
if self.event_request_chunk_size > self.max_event_queue_size:
9292
logger.warning(
93-
f"DevCycle: event_request_chunk_size: {self.event_request_chunk_size} must be smaller than max_event_queue_size: { self.max_event_queue_size}"
93+
f"DevCycle: event_request_chunk_size: {self.event_request_chunk_size} must be smaller than max_event_queue_size: {self.max_event_queue_size}"
9494
)
9595
self.event_request_chunk_size = 100
9696

devcycle_python_sdk/protobuf/utils.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,17 @@ def create_nullable_custom_data(val: Optional[dict]) -> pb2.NullableCustomData:
3434
if value is None:
3535
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Null) # type: ignore
3636
elif isinstance(value, bool):
37-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Bool, boolValue=value) # type: ignore
37+
values[key] = pb2.CustomDataValue(
38+
type=pb2.CustomDataType.Bool, boolValue=value
39+
) # type: ignore
3840
elif isinstance(value, str):
39-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Str, stringValue=value) # type: ignore
41+
values[key] = pb2.CustomDataValue(
42+
type=pb2.CustomDataType.Str, stringValue=value
43+
) # type: ignore
4044
elif isinstance(value, (int, float)):
41-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Num, doubleValue=value) # type: ignore
45+
values[key] = pb2.CustomDataValue(
46+
type=pb2.CustomDataType.Num, doubleValue=value
47+
) # type: ignore
4248
else:
4349
logger.warning(
4450
f"Custom Data contains data type that can't be written, will be ignored. Key: {key}, Type: {str(type(value))}"

devcycle_python_sdk/protobuf/variableForUserParams_pb2.py

Lines changed: 33 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/django-app/manage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/usr/bin/env python
22
"""Django's command-line utility for administrative tasks."""
3+
34
import os
45
import sys
56

0 commit comments

Comments
 (0)